-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!(@charcoal-ui/icons): remove dompurify from v4. #643
Conversation
Visit the preview URL for this PR (updated for commit 7516462): https://pixiv-charcoal-web--pr643-fix-remove-dompurify-6krg77r5.web.app (expires Thu, 31 Oct 2024 05:20:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
Size Change: -916 B (0%) Total Size: 26 MB
ℹ️ View Unchanged
|
c7d41fc
to
eaa7587
Compare
…tize the svg content before passing to charcoal
eaa7587
to
7516462
Compare
get trusted() { | ||
return true | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trusted見て一回warning出してもいいけど、devであるか確認するのがやや複雑でやらないほうがまだ良さそうです。
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません