fix: rename use theme key and update type #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue4u
commented
Oct 4, 2024
packages/styled/src/helper.ts
Outdated
| const isDark = useMedia('(prefers-color-scheme: dark)') | ||
| const media = isDark !== undefined ? (isDark ? 'dark' : 'light') : undefined | ||
| const [local, setTheme, ready] = useLocalStorage<string>(key) | ||
| const [local, setTheme, ready] = useLocalStorage<typeof media>(localStorageKey) |
There was a problem hiding this comment.
Question: does charcoal allow theme is not "light" | "dark" | undefined?
Changing return type should be breaking but if we never allowed custom string this should be a minor change.
naporin0624
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
"light" | "dark" | undefined動作確認環境
チェックリスト
不要なチェック項目は消して構いません