-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: token migration guide #614
Draft
naporin0624
wants to merge
9
commits into
v4.0.0
Choose a base branch
from
naporitan/token-migration-guide
base: v4.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naporin0624
commented
Jul 31, 2024
naporin0624
commented
Aug 15, 2024
Comment on lines
+126
to
+148
### カラーの上書き | ||
|
||
ライトモードの場合は `:root`、ダークモードの場合は `:root[data-theme='dark']` セレクターに対応しています。`@charcoal-react/dist/index.css` の後に記述することで、トークンを上書きできます。 | ||
|
||
#### ライトモード | ||
|
||
**例**: ブランドカラーを変更する場合 | ||
|
||
```css | ||
:root { | ||
--charcoal-color-container-primary-default: #0096fa; | ||
} | ||
``` | ||
|
||
#### ダークモード | ||
|
||
**例**: ブランドカラーを変更する場合 | ||
|
||
```css | ||
:root[data-theme='dark'] { | ||
--charcoal-color-container-primary-default: #0096fa; | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新トークン上書きはここから
…an/token-migration-guide
多分いらないきがする |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
link2
surface5
surface10
が figma 上に存在しないため移行を作成できていない。動作確認環境
チェックリスト
不要なチェック項目は消して構いません