-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Design Tokens, Add CSS Variables Tests, and Introduce Custom CSS Variables for @charcoal-ui/react
#604
Conversation
e868021
to
3a1cc80
Compare
Visit the preview URL for this PR (updated for commit ce5294c): https://pixiv-charcoal-web--pr604-naporitan-replace-to-znc9u8yt.web.app (expires Wed, 27 Nov 2024 06:52:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
Size Change: +426 B (+0.08%) Total Size: 540 kB
ℹ️ View Unchanged
|
…an/replace-token1
…an/replace-token1
fix: update design token usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#652 で殆どの問題が修正されたので一旦v4にマージすると良さそうです
TODO:
- Modal背景
- SegmentedControlのデザイン更新
やったこと
@charcoal-ui/react
.動作確認環境
チェックリスト
不要なチェック項目は消して構いません