feat: add modal button aria label and export ModalCloseButton #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue4u
changed the title
yue4u
commented
Jun 3, 2024
| @@ -74,6 +75,7 @@ const Modal = forwardRef<HTMLDivElement, ModalProps>(function ModalInner( | |||
| onClose, | |||
| className, | |||
| isOpen = false, | |||
| closeButtonAriaLabel = 'Close', | |||
There was a problem hiding this comment.
make this a prop for i18n
| @@ -224,7 +228,7 @@ const ModalBackground = animated(styled.div<{ | |||
| } | |||
| `) | |||
|
|
|||
| const ModalCrossButton = styled(IconButton)` | |||
| export const ModalCloseButton = styled(IconButton)` | |||
There was a problem hiding this comment.
In case user want to set isDismissable to false and handle it themselves, for example, pass different onClose for close button and background.
| @@ -36,7 +36,7 @@ const IconButton = forwardRef<ClickableElement, IconButtonProps>( | |||
| $variant={variant} | |||
| $isActive={isActive} | |||
| > | |||
| <pixiv-icon name={icon} /> | |||
| <pixiv-icon aria-hidden="true" name={icon} /> | |||
There was a problem hiding this comment.
This changes all IconButtons. If it's too broad to decide I'll make this a separate PR.
yue4u
force-pushed
the
fix/modal-button-aria-label
branch
from
e4d7a5a to
02037a7
Compare
mimokmt
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
closeButtonAriaLabelforModalandaria-hiddenfor pixiv-icon inside.ModalCloseButtonBefore:
After:
動作確認環境
チェックリスト
不要なチェック項目は消して構いません