Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dropdown selector v4 styled to css #549

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat: dropdown selector v4 styled to css #549

merged 4 commits into from
Jun 12, 2024

Conversation

toshusai
Copy link
Contributor

やったこと

  • Change styled to css.

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@toshusai toshusai added the major label May 31, 2024
@toshusai toshusai self-assigned this May 31, 2024
@toshusai toshusai requested a review from naporin0624 May 31, 2024 09:01
@toshusai toshusai changed the base branch from toshusai/textarea-change-styled-to-css to v4.0.0 June 7, 2024 08:36
@toshusai
Merge branch 'v4.0.0' of https://github.com/pixiv/charcoal into toshu…
1cfb61b 
…sai/dropdown-selector-change-styled-to-css
@toshusai toshusai temporarily deployed to preview-channel June 7, 2024 08:41 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Size Change: -5.55 kB (-0.18%)

Total Size: 3.08 MB

Filename Size Change
./packages/react/dist/components/DropdownSelector/Divider.d.ts 0 B -230 B (removed) 🏆
./packages/react/dist/components/DropdownSelector/DropdownMenuItem.d.ts 0 B -308 B (removed) 🏆
./packages/react/dist/components/DropdownSelector/index.d.ts 703 B +57 B (+8.82%) 🔍
./packages/react/dist/components/DropdownSelector/ListItem/index.d.ts 490 B -178 B (-26.65%) 🎉
./packages/react/dist/components/DropdownSelector/MenuItem/index.d.ts 771 B +260 B (+50.88%) 🆘
./packages/react/dist/components/DropdownSelector/MenuItem/internals/useMenuItemHandleKeyDown.d.ts 480 B -3 B (-0.62%)
./packages/react/dist/components/DropdownSelector/MenuItemGroup/index.d.ts 414 B -62 B (-13.03%) 👏
./packages/react/dist/components/DropdownSelector/MenuList/index.d.ts 540 B -159 B (-22.75%) 🎉
./packages/react/dist/components/DropdownSelector/Popover/index.d.ts 630 B +22 B (+3.62%)
./packages/react/dist/index.cjs.js 53.1 kB -2.97 kB (-5.31%) ✅
./packages/react/dist/index.esm.js 47.3 kB -2.4 kB (-4.82%) ✅
./packages/react/dist/components/DropdownSelector/Divider/index.d.ts 105 B +105 B (new file) 🆕
./packages/react/dist/components/DropdownSelector/DropdownMenuItem/index.d.ts 313 B +313 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./packages/foundation/dist/border-radius.d.ts 692 B
./packages/foundation/dist/breakpoint.d.ts 225 B
./packages/foundation/dist/color.d.ts 171 B
./packages/foundation/dist/effect.d.ts 1.08 kB
./packages/foundation/dist/grid.d.ts 396 B
./packages/foundation/dist/index.cjs.js 2.82 kB
./packages/foundation/dist/index.d.ts 230 B
./packages/foundation/dist/index.esm.js 1.44 kB
./packages/foundation/dist/spacing.d.ts 305 B
./packages/foundation/dist/typography.d.ts 790 B
./packages/icons-cli/dist/index.js 20.3 kB
./packages/icons/dist/charcoalIconFiles.d.ts 4.63 kB
./packages/icons/dist/index.cjs.js 9.47 kB
./packages/icons/dist/index.d.ts 478 B
./packages/icons/dist/index.esm.js 7.96 kB
./packages/icons/dist/loaders/CharcoalIconFilesLoader.d.ts 7.33 kB
./packages/icons/dist/loaders/CustomIconLoader.d.ts 417 B
./packages/icons/dist/loaders/index.d.ts 181 B
./packages/icons/dist/loaders/Loadable.d.ts 98 B
./packages/icons/dist/loaders/PixivIconLoadError.d.ts 153 B
./packages/icons/dist/PixivIcon.d.ts 1.46 kB
./packages/icons/dist/PixivIcon.story.d.ts 428 B
./packages/icons/dist/PixivIcon.test.d.ts 55 B
./packages/icons/dist/ssr.d.ts 75 B
./packages/react-sandbox/dist/_lib/compat.d.ts 427 B
./packages/react-sandbox/dist/components/Carousel/index.d.ts 1.35 kB
./packages/react-sandbox/dist/components/CarouselButton/index.d.ts 619 B
./packages/react-sandbox/dist/components/Filter/index.d.ts 1.12 kB
./packages/react-sandbox/dist/components/HintText/index.d.ts 298 B
./packages/react-sandbox/dist/components/icons/Base.d.ts 706 B
./packages/react-sandbox/dist/components/icons/DotsIcon.d.ts 282 B
./packages/react-sandbox/dist/components/icons/InfoIcon.d.ts 87 B
./packages/react-sandbox/dist/components/icons/NextIcon.d.ts 281 B
./packages/react-sandbox/dist/components/icons/WedgeIcon.d.ts 462 B
./packages/react-sandbox/dist/components/Layout/index.d.ts 2.07 kB
./packages/react-sandbox/dist/components/LeftMenu/index.d.ts 382 B
./packages/react-sandbox/dist/components/MenuListItem/index.d.ts 1.79 kB
./packages/react-sandbox/dist/components/Pager/index.d.ts 529 B
./packages/react-sandbox/dist/components/SwitchCheckbox/index.d.ts 340 B
./packages/react-sandbox/dist/components/TextEllipsis/helper.d.ts 235 B
./packages/react-sandbox/dist/components/TextEllipsis/index.d.ts 381 B
./packages/react-sandbox/dist/components/WithIcon/index.d.ts 1.07 kB
./packages/react-sandbox/dist/foundation/constants.d.ts 208 B
./packages/react-sandbox/dist/foundation/hooks.d.ts 1.04 kB
./packages/react-sandbox/dist/foundation/support.d.ts 131 B
./packages/react-sandbox/dist/foundation/utils.d.ts 613 B
./packages/react-sandbox/dist/hooks/index.d.ts 148 B
./packages/react-sandbox/dist/index.cjs.js 62.9 kB
./packages/react-sandbox/dist/index.d.ts 1.34 kB
./packages/react-sandbox/dist/index.esm.js 53.2 kB
./packages/react-sandbox/dist/misc/storybook-helper.d.ts 343 B
./packages/react-sandbox/dist/styled.d.ts 12.3 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/decorator.d.ts 184 B
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/decorator.js 4 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/index.d.ts 3.09 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/index.js 3.13 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/manager.js 32 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/dist/preview.js 3.62 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/node_modules/polished/dist/polished.cjs.js 127 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/node_modules/polished/dist/polished.esm.js 125 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/node_modules/polished/dist/polished.js 135 kB
./packages/react-sandbox/node_modules/@storybook/addon-actions/node_modules/polished/dist/polished.min.js 35 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/index.d.ts 931 B
./packages/react-sandbox/node_modules/@storybook/channels/dist/index.js 10.5 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/main-c55d8855.d.ts 1.53 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/postmessage/index.d.ts 1.39 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/postmessage/index.js 8.43 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/websocket/index.d.ts 1.39 kB
./packages/react-sandbox/node_modules/@storybook/channels/dist/websocket/index.js 4.68 kB
./packages/react-sandbox/node_modules/@storybook/client-logger/dist/index.d.ts 1.26 kB
./packages/react-sandbox/node_modules/@storybook/client-logger/dist/index.js 2.54 kB
./packages/react-sandbox/node_modules/@storybook/core-common/dist/index.d.ts 8.68 kB
./packages/react-sandbox/node_modules/@storybook/core-common/dist/index.js 32.2 kB
./packages/react-sandbox/node_modules/@storybook/docs-tools/dist/index.d.ts 5.72 kB
./packages/react-sandbox/node_modules/@storybook/docs-tools/dist/index.js 16.9 kB
./packages/react-sandbox/node_modules/@storybook/node-logger/dist/index.d.ts 9.9 kB
./packages/react-sandbox/node_modules/@storybook/node-logger/dist/index.js 156 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/addons.d.ts 2.73 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/addons.js 11.3 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/client-api.d.ts 1.69 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/client-api.js 65.6 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/ClientApi-24d2bfd0.d.ts 3.24 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/composeConfigs-62a04721.d.ts 849 B
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/core-client.d.ts 3.11 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/core-client.js 148 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/hooks-655fa363.d.ts 8.8 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/index.d.ts 1.48 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/index.js 164 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/preview-web.d.ts 14.2 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/preview-web.js 134 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/queryparams-d12445b8.d.ts 236 B
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/sortStories-436f1964.d.ts 5.86 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/store.d.ts 3.55 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/store.js 52.4 kB
./packages/react-sandbox/node_modules/@storybook/preview-api/dist/StoryStore-f7424ddf.d.ts 5.68 kB
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/preset.d.ts 90 kB
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/preset.js 1.93 kB
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/react-16.d.ts 216 B
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/react-16.js 1.38 kB
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/react-18.d.ts 250 B
./packages/react-sandbox/node_modules/@storybook/react-dom-shim/dist/react-18.js 1.87 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/entry-preview-docs.d.ts 896 B
./packages/react-sandbox/node_modules/@storybook/react/dist/entry-preview-docs.js 27.9 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/entry-preview.d.ts 472 B
./packages/react-sandbox/node_modules/@storybook/react/dist/entry-preview.js 2.71 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/index.d.ts 10.1 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/index.js 4.25 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/preset.d.ts 215 B
./packages/react-sandbox/node_modules/@storybook/react/dist/preset.js 1.54 kB
./packages/react-sandbox/node_modules/@storybook/react/dist/types-0fc72a6d.d.ts 317 B
./packages/react-sandbox/node_modules/@storybook/types/dist/index.d.ts 160 kB
./packages/react-sandbox/node_modules/@storybook/types/dist/index.js 1.27 kB
./packages/react-sandbox/node_modules/acorn/dist/acorn.d.ts 5.22 kB
./packages/react-sandbox/node_modules/acorn/dist/acorn.js 200 kB
./packages/react-sandbox/node_modules/acorn/dist/acorn.mjs.d.ts 49 B
./packages/react-sandbox/node_modules/acorn/dist/bin.js 2.29 kB
./packages/react-sandbox/node_modules/esbuild-register/dist/loader.d.ts 97 B
./packages/react-sandbox/node_modules/esbuild-register/dist/loader.js 421 B
./packages/react-sandbox/node_modules/esbuild-register/dist/node.d.ts 791 B
./packages/react-sandbox/node_modules/esbuild-register/dist/node.js 178 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/bin.d.ts 64 B
./packages/react-sandbox/node_modules/glob/dist/cjs/src/bin.js 9.66 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/glob.d.ts 12.8 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/glob.js 8.06 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/has-magic.d.ts 760 B
./packages/react-sandbox/node_modules/glob/dist/cjs/src/has-magic.js 1.06 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/ignore.d.ts 670 B
./packages/react-sandbox/node_modules/glob/dist/cjs/src/ignore.js 3.79 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/index.d.ts 6 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/index.js 2.86 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/pattern.d.ts 2.15 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/pattern.js 7.3 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/processor.d.ts 2.14 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/processor.js 10.8 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/walker.d.ts 4.21 kB
./packages/react-sandbox/node_modules/glob/dist/cjs/src/walker.js 11.5 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/glob.d.ts 12.8 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/glob.js 7.86 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/has-magic.d.ts 760 B
./packages/react-sandbox/node_modules/glob/dist/mjs/has-magic.js 917 B
./packages/react-sandbox/node_modules/glob/dist/mjs/ignore.d.ts 670 B
./packages/react-sandbox/node_modules/glob/dist/mjs/ignore.js 3.63 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/index.d.ts 6 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/index.js 1.65 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/pattern.d.ts 2.15 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/pattern.js 7.16 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/processor.d.ts 2.14 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/processor.js 10.5 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/walker.d.ts 4.21 kB
./packages/react-sandbox/node_modules/glob/dist/mjs/walker.js 11.2 kB
./packages/react-sandbox/node_modules/minimatch/dist/cjs/assert-valid-pattern.d.ts 115 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/assert-valid-pattern.js 492 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/ast.d.ts 758 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/ast.js 22.8 kB
./packages/react-sandbox/node_modules/minimatch/dist/cjs/brace-expressions.d.ts 251 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/brace-expressions.js 5.76 kB
./packages/react-sandbox/node_modules/minimatch/dist/cjs/escape.d.ts 647 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/escape.js 968 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/index.d.ts 3.9 kB
./packages/react-sandbox/node_modules/minimatch/dist/cjs/index.js 40.3 kB
./packages/react-sandbox/node_modules/minimatch/dist/cjs/unescape.d.ts 788 B
./packages/react-sandbox/node_modules/minimatch/dist/cjs/unescape.js 973 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/assert-valid-pattern.d.ts 115 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/assert-valid-pattern.js 336 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/ast.d.ts 758 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/ast.js 22.5 kB
./packages/react-sandbox/node_modules/minimatch/dist/mjs/brace-expressions.d.ts 251 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/brace-expressions.js 5.63 kB
./packages/react-sandbox/node_modules/minimatch/dist/mjs/escape.d.ts 647 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/escape.js 848 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/index.d.ts 3.9 kB
./packages/react-sandbox/node_modules/minimatch/dist/mjs/index.js 38.9 kB
./packages/react-sandbox/node_modules/minimatch/dist/mjs/unescape.d.ts 788 B
./packages/react-sandbox/node_modules/minimatch/dist/mjs/unescape.js 847 B
./packages/react-sandbox/node_modules/minipass/dist/cjs/index.d.ts 19.5 kB
./packages/react-sandbox/node_modules/minipass/dist/cjs/index.js 33.8 kB
./packages/react-sandbox/node_modules/minipass/dist/mjs/index.d.ts 19.5 kB
./packages/react-sandbox/node_modules/minipass/dist/mjs/index.js 33.2 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/index.js 1.79 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/md5.js 7.01 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/native.js 271 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/nil.js 188 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/parse.js 1.38 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/regex.js 267 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/rng.js 927 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/sha1.js 2.61 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/stringify.js 1.79 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/v1.js 3.6 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/v3.js 414 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/v35.js 2.08 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/v4.js 1.01 kB
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/v5.js 417 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/validate.js 410 B
./packages/react-sandbox/node_modules/uuid/dist/commonjs-browser/version.js 474 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/index.js 412 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/md5.js 6.88 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/native.js 137 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/nil.js 54 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/parse.js 1.11 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/regex.js 133 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/rng.js 838 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/sha1.js 2.47 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/stringify.js 1.49 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/v1.js 3.32 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/v3.js 107 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/v35.js 1.78 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/v4.js 680 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/v5.js 110 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/validate.js 141 B
./packages/react-sandbox/node_modules/uuid/dist/esm-browser/version.js 200 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/index.js 412 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/md5.js 281 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/native.js 80 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/nil.js 54 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/parse.js 1.11 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-node/regex.js 133 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/rng.js 323 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/sha1.js 284 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/stringify.js 1.49 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-node/v1.js 3.32 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-node/v3.js 107 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/v35.js 1.78 kB
./packages/react-sandbox/node_modules/uuid/dist/esm-node/v4.js 680 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/v5.js 110 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/validate.js 141 B
./packages/react-sandbox/node_modules/uuid/dist/esm-node/version.js 200 B
./packages/react-sandbox/node_modules/uuid/dist/index.js 1.76 kB
./packages/react-sandbox/node_modules/uuid/dist/md5-browser.js 7.01 kB
./packages/react-sandbox/node_modules/uuid/dist/md5.js 550 B
./packages/react-sandbox/node_modules/uuid/dist/native-browser.js 271 B
./packages/react-sandbox/node_modules/uuid/dist/native.js 350 B
./packages/react-sandbox/node_modules/uuid/dist/nil.js 188 B
./packages/react-sandbox/node_modules/uuid/dist/parse.js 1.38 kB
./packages/react-sandbox/node_modules/uuid/dist/regex.js 267 B
./packages/react-sandbox/node_modules/uuid/dist/rng-browser.js 927 B
./packages/react-sandbox/node_modules/uuid/dist/rng.js 549 B
./packages/react-sandbox/node_modules/uuid/dist/sha1-browser.js 2.61 kB
./packages/react-sandbox/node_modules/uuid/dist/sha1.js 553 B
./packages/react-sandbox/node_modules/uuid/dist/stringify.js 1.79 kB
./packages/react-sandbox/node_modules/uuid/dist/uuid-bin.js 2.03 kB
./packages/react-sandbox/node_modules/uuid/dist/v1.js 3.6 kB
./packages/react-sandbox/node_modules/uuid/dist/v3.js 414 B
./packages/react-sandbox/node_modules/uuid/dist/v35.js 2.08 kB
./packages/react-sandbox/node_modules/uuid/dist/v4.js 1.01 kB
./packages/react-sandbox/node_modules/uuid/dist/v5.js 417 B
./packages/react-sandbox/node_modules/uuid/dist/validate.js 410 B
./packages/react-sandbox/node_modules/uuid/dist/version.js 474 B
./packages/react/dist/_lib/compat.d.ts 1.54 kB
./packages/react/dist/_lib/createDivComponent.d.ts 581 B
./packages/react/dist/_lib/index.d.ts 1.02 kB
./packages/react/dist/_lib/useClassNames.d.ts 192 B
./packages/react/dist/_lib/useForwardedRef.d.ts 169 B
./packages/react/dist/components/Button/index.d.ts 854 B
./packages/react/dist/components/Checkbox/CheckboxInput/index.d.ts 628 B
./packages/react/dist/components/Checkbox/CheckboxWithLabel.d.ts 307 B
./packages/react/dist/components/Checkbox/index.d.ts 668 B
./packages/react/dist/components/Clickable/index.d.ts 624 B
./packages/react/dist/components/DropdownSelector/DropdownPopover.d.ts 486 B
./packages/react/dist/components/DropdownSelector/MenuItem/internals/handleFocusByKeyBoard.d.ts 373 B
./packages/react/dist/components/DropdownSelector/MenuList/internals/getValuesRecursive.d.ts 412 B
./packages/react/dist/components/DropdownSelector/MenuList/MenuListContext.d.ts 405 B
./packages/react/dist/components/DropdownSelector/Popover/usePreventScroll.d.ts 140 B
./packages/react/dist/components/DropdownSelector/utils/findPreviewRecursive.d.ts 411 B
./packages/react/dist/components/FieldLabel/index.d.ts 492 B
./packages/react/dist/components/Icon/index.d.ts 498 B
./packages/react/dist/components/IconButton/index.d.ts 679 B
./packages/react/dist/components/LoadingSpinner/index.d.ts 678 B
./packages/react/dist/components/Modal/__stories__/InternalScrollStory.d.ts 189 B
./packages/react/dist/components/Modal/Dialog/index.d.ts 426 B
./packages/react/dist/components/Modal/index.d.ts 2.09 kB
./packages/react/dist/components/Modal/ModalBackgroundContext.d.ts 231 B
./packages/react/dist/components/Modal/ModalPlumbing.d.ts 1.62 kB
./packages/react/dist/components/Modal/useCustomModalOverlay.d.ts 632 B
./packages/react/dist/components/Radio/index.d.ts 890 B
./packages/react/dist/components/SegmentedControl/index.d.ts 758 B
./packages/react/dist/components/SegmentedControl/RadioGroupContext.d.ts 362 B
./packages/react/dist/components/Switch/index.d.ts 452 B
./packages/react/dist/components/Switch/SwitchInput/index.d.ts 482 B
./packages/react/dist/components/Switch/SwitchWithLabel.d.ts 308 B
./packages/react/dist/components/TagItem/index.d.ts 892 B
./packages/react/dist/components/TextArea/index.d.ts 1.33 kB
./packages/react/dist/components/TextField/AssistiveText/index.d.ts 559 B
./packages/react/dist/components/TextField/index.d.ts 1.44 kB
./packages/react/dist/components/TextField/useFocusWithClick.d.ts 242 B
./packages/react/dist/core/CharcoalProvider.d.ts 661 B
./packages/react/dist/core/ComponentAbstraction.d.ts 933 B
./packages/react/dist/core/OverlayProvider.d.ts 101 B
./packages/react/dist/core/SSRProvider.d.ts 242 B
./packages/react/dist/index.d.ts 1.91 kB
./packages/react/dist/styled.d.ts 12.3 kB
./packages/react/node_modules/caniuse-lite/dist/lib/statuses.js 306 B
./packages/react/node_modules/caniuse-lite/dist/lib/supported.js 111 B
./packages/react/node_modules/caniuse-lite/dist/unpacker/agents.js 1.44 kB
./packages/react/node_modules/caniuse-lite/dist/unpacker/browsers.js 57 B
./packages/react/node_modules/caniuse-lite/dist/unpacker/browserVersions.js 71 B
./packages/react/node_modules/caniuse-lite/dist/unpacker/feature.js 1.36 kB
./packages/react/node_modules/caniuse-lite/dist/unpacker/features.js 141 B
./packages/react/node_modules/caniuse-lite/dist/unpacker/index.js 198 B
./packages/react/node_modules/caniuse-lite/dist/unpacker/region.js 550 B
./packages/styled/dist/addThemeUtils.story.d.ts 302 B
./packages/styled/dist/builders/border.d.ts 685 B
./packages/styled/dist/builders/borderRadius.d.ts 440 B
./packages/styled/dist/builders/colors.d.ts 1.3 kB
./packages/styled/dist/builders/elementEffect.d.ts 533 B
./packages/styled/dist/builders/o.d.ts 5.91 kB
./packages/styled/dist/builders/outline.d.ts 638 B
./packages/styled/dist/builders/size.d.ts 1.19 kB
./packages/styled/dist/builders/spacing.d.ts 1.17 kB
./packages/styled/dist/builders/transition.d.ts 287 B
./packages/styled/dist/builders/typography.d.ts 624 B
./packages/styled/dist/defineThemeVariables.test.d.ts 66 B
./packages/styled/dist/factories/lib.d.ts 3.96 kB
./packages/styled/dist/helper.d.ts 2.01 kB
./packages/styled/dist/index.cjs.js 30.9 kB
./packages/styled/dist/index.d.ts 6.82 kB
./packages/styled/dist/index.esm.js 27.6 kB
./packages/styled/dist/index.test.d.ts 204 B
./packages/styled/dist/internals/index.d.ts 1.6 kB
./packages/styled/dist/SetThemeScript.d.ts 905 B
./packages/styled/dist/storyHelper.d.ts 386 B
./packages/styled/dist/styles/assertiveRingCss.d.ts 141 B
./packages/styled/dist/styles/disabledCss.d.ts 131 B
./packages/styled/dist/styles/focusVisibleFocusRingCss.d.ts 318 B
./packages/styled/dist/TokenInjector.d.ts 505 B
./packages/styled/dist/util.d.ts 4.24 kB
./packages/styled/dist/utils/addThemeUtils.d.ts 383 B
./packages/styled/dist/utils/CharcoalStyledTheme.d.ts 1.43 kB
./packages/styled/dist/utils/gap.d.ts 473 B
./packages/styled/dist/utils/helpers/pxIfNum.d.ts 99 B
./packages/styled/dist/utils/helpers/SpacingType.d.ts 137 B
./packages/styled/dist/utils/margin.d.ts 905 B
./packages/styled/dist/utils/padding.d.ts 935 B
./packages/styled/dist/utils/typographyCss.d.ts 207 B
./packages/tailwind-config/dist/_lib/compat.d.ts 423 B
./packages/tailwind-config/dist/_lib/TailwindBuild.d.ts 755 B
./packages/tailwind-config/dist/colors/plugin.d.ts 443 B
./packages/tailwind-config/dist/colors/plugin.test.d.ts 52 B
./packages/tailwind-config/dist/colors/toTailwindConfig.d.ts 399 B
./packages/tailwind-config/dist/colors/toTailwindConfig.test.d.ts 62 B
./packages/tailwind-config/dist/colors/utils.d.ts 347 B
./packages/tailwind-config/dist/docs/borderRadius/BorderRadius.d.ts 119 B
./packages/tailwind-config/dist/docs/borderRadius/index.d.ts 175 B
./packages/tailwind-config/dist/docs/colors/Colors.d.ts 107 B
./packages/tailwind-config/dist/docs/colors/index.d.ts 201 B
./packages/tailwind-config/dist/docs/colors/TextBgColor.d.ts 175 B
./packages/tailwind-config/dist/docs/colors/TextBgColor.story.d.ts 298 B
./packages/tailwind-config/dist/docs/colors/TextColors.d.ts 115 B
./packages/tailwind-config/dist/docs/gradient/Gradients.d.ts 113 B
./packages/tailwind-config/dist/docs/gradient/index.d.ts 433 B
./packages/tailwind-config/dist/docs/gradient/utils.d.ts 120 B
./packages/tailwind-config/dist/docs/index.d.ts 360 B
./packages/tailwind-config/dist/docs/screens/index.d.ts 160 B
./packages/tailwind-config/dist/docs/screens/Screens.d.ts 109 B
./packages/tailwind-config/dist/docs/spacing/index.d.ts 160 B
./packages/tailwind-config/dist/docs/spacing/Spacing.d.ts 109 B
./packages/tailwind-config/dist/docs/typography/HalfLeading.d.ts 117 B
./packages/tailwind-config/dist/docs/typography/index.d.ts 346 B
./packages/tailwind-config/dist/docs/typography/Sizes.d.ts 105 B
./packages/tailwind-config/dist/foundation.d.ts 360 B
./packages/tailwind-config/dist/gradient/plugin.d.ts 816 B
./packages/tailwind-config/dist/gradient/plugin.test.d.ts 52 B
./packages/tailwind-config/dist/index.cjs.js 11.4 kB
./packages/tailwind-config/dist/index.d.ts 378 B
./packages/tailwind-config/dist/index.esm.js 9.56 kB
./packages/tailwind-config/dist/index.test.d.ts 51 B
./packages/tailwind-config/dist/types.d.ts 855 B
./packages/tailwind-config/dist/typography/plugin.d.ts 146 B
./packages/tailwind-config/dist/util.d.ts 661 B
./packages/tailwind-diff/dist/commands/check.d.ts 296 B
./packages/tailwind-diff/dist/commands/check.js 4.37 kB
./packages/tailwind-diff/dist/commands/dump.d.ts 185 B
./packages/tailwind-diff/dist/commands/dump.js 1.26 kB
./packages/tailwind-diff/dist/defer.d.ts 164 B
./packages/tailwind-diff/dist/defer.js 815 B
./packages/tailwind-diff/dist/index.d.ts 46 B
./packages/tailwind-diff/dist/index.js 1.84 kB
./packages/tailwind-diff/dist/packageManager.d.ts 323 B
./packages/tailwind-diff/dist/packageManager.js 1.85 kB
./packages/tailwind-diff/dist/style.d.ts 436 B
./packages/tailwind-diff/dist/style.js 2.68 kB
./packages/tailwind-diff/dist/withPackages.d.ts 464 B
./packages/tailwind-diff/dist/withPackages.js 3.24 kB
./packages/theme/dist/abstract-theme.d.ts 1.19 kB
./packages/theme/dist/default.d.ts 163 B
./packages/theme/dist/index.cjs.js 5.49 kB
./packages/theme/dist/index.d.ts 121 B
./packages/theme/dist/index.esm.js 3.49 kB
./packages/theme/dist/theme.d.ts 2.87 kB
./packages/utils/dist/index.cjs.js 6.81 kB
./packages/utils/dist/index.d.ts 3.17 kB
./packages/utils/dist/index.esm.js 4.67 kB

compressed-size-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8b1988a):

https://pixiv-charcoal-web--pr549-toshusai-dropdown-se-9g9gvhph.web.app

(expires Wed, 19 Jun 2024 08:33:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0

@toshusai
Copy link
Contributor Author

toshusai commented Jun 7, 2024

https://github.com/pixiv/charcoal/actions/runs/9414206612/job/25932696689?pr=549
expected diffs.

@toshusai toshusai added the image snapshots update Pull requests that update image snapshots label Jun 7, 2024
@toshusai toshusai marked this pull request as ready for review June 7, 2024 09:04
naporin0624
naporin0624 reviewed Jun 12, 2024
View reviewed changes
packages/react/src/components/DropdownSelector/DropdownMenuItem/index.tsx Outdated
)}
<span
className="charcoal-dropdown-selector-menu-item"
aria-selected={isSelected}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-selected is used for grid-cell, option, row, and tab roles, so data-selected is preferred.

https://www.osaka-kyoiku.ac.jp/~joho/html5_ref/wai-aria/states_and_properties.html#aria-selected

@toshusai toshusai merged commit c1be208 into v4.0.0 Jun 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naporin0624 naporin0624 naporin0624 approved these changes

Assignees

@toshusai toshusai

Labels
image snapshots update Pull requests that update image snapshots major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toshusai @naporin0624