Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: textarea change styled to css #548

Conversation

toshusai
Copy link
Contributor

やったこと

  • Change styled to css.

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@toshusai toshusai added the major label May 31, 2024
@toshusai toshusai requested a review from naporin0624 May 31, 2024 03:36
@toshusai toshusai self-assigned this May 31, 2024
@toshusai toshusai changed the title feat: change styled to css feat: textarea change styled to css May 31, 2024
@toshusai toshusai marked this pull request as ready for review May 31, 2024 06:08
width: calc(100% / 0.875);
font-size: calc(14px / 0.875);
line-height: calc(22px / 0.875);
padding: calc(9px / 0.875) calc(8px / 0.875) 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-bottom-padding style seems to be missing.

Copy link
Member

@naporin0624 naporin0624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toshusai toshusai merged commit c70defa into toshusai/textfield-change-to-styled-to-css Jun 7, 2024
1 check passed
@toshusai toshusai mentioned this pull request Jun 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants