Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <IconButton>でDOM Elementに不要な属性が渡されるのを防ぐ #414

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: <IconButton>でDOM Elementに不要な属性が渡されるのを防ぐ #414

merged 1 commit into from
Dec 4, 2023

Conversation

momoogles
Copy link

やったこと

  • <IconButton>のattrs()から、width、height、またthemeなどのプロパティまでもがDOM Elementに渡されていたのを修正した

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@toshusai toshusai added the patch label Dec 4, 2023
toshusai
toshusai approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@toshusai toshusai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. It looks good to me.

@toshusai toshusai merged commit 32db350 into pixiv:main Dec 4, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshusai toshusai toshusai approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momoogles @toshusai