fix: textarea focus with proper padding #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue4u
commented
Oct 10, 2023
| padding: calc(9px / 0.875) 0 ${(p) => (p.noBottomPadding ? 0 : '')}; | ||
| padding: calc(9px / 0.875) calc(8px / 0.875) | ||
| ${(p) => (p.withCountPadding ? 0 : '')}; | ||
| /* Using padding on textarea will cause text overflow */ |
There was a problem hiding this comment.
maybe replace padding with border in the future?
|
Thank you very much for your PR. I've considered a different approach and created a new PR based on that. I'd love to hear your thoughts on it. |
toshusai
approved these changes
Oct 20, 2023
toshusai
approved these changes
Oct 20, 2023
|
With this PR, one issue is addressed, but another problem has been identified. When clicking on borderBottom, the cursor ends up behind the text that follows. We might want to consider using focus() to properly restore the click position. |
|
Thank you for submitting the PR. This PR has resolved the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
fix textarea focus issue especially when count is shown.
before
textarea-before-2.mp4
after
textarea-after-3.mp4
動作確認環境
チェックリスト
不要なチェック項目は消して構いません