Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): remove @charcoal/styled from checkbox #377

Merged
merged 21 commits into from
Dec 13, 2023
+1,350 −410
Merged

feat(react): remove @charcoal/styled from checkbox #377

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
64ea1c1
feat(react): replace static css
naporin0624 Aug 16, 2023
0412113
feat(react): replace disabled
naporin0624 Aug 16, 2023
6834013
feat(react): replace hover press theme
naporin0624 Aug 16, 2023
7e50f1c
feat(react): replace outline theme
naporin0624 Aug 16, 2023
9057e2a
feat(react): merge transition
naporin0624 Aug 16, 2023
b5c6f00
refactor(react): refactor checked styling
naporin0624 Aug 16, 2023
8d19bd7
refactor(react): apply nested
naporin0624 Aug 16, 2023
dfc1504
refactor(react): refactor selector
naporin0624 Aug 23, 2023
ff9dca9
refactor(react): remove comment
naporin0624 Sep 8, 2023
e66800e
Merge branch 'main' of ssh://github.com/pixiv/charcoal into feat/remo…
naporin0624 Sep 27, 2023
bb7223d
feat(react): add invalid story
naporin0624 Sep 27, 2023
e3775fe
feat(react): use aria-invalid
naporin0624 Sep 27, 2023
5260c13
feat(react): update radio version
naporin0624 Sep 27, 2023
d2fbbbf
chore: add invalid props description
naporin0624 Sep 27, 2023
9885851
chore: fix @swc/helpers version
naporin0624 Sep 27, 2023
0a50aab
chore: fix conflict yarn.lock
naporin0624 Nov 22, 2023
269aa8b
chore: fix conflict yarn.lock
naporin0624 Nov 22, 2023
5d83b07
Merge branch 'main' of ssh://github.com/pixiv/charcoal into feat/remo…
naporin0624 Nov 22, 2023
ae8c58f
chore: update yarn.lock
naporin0624 Nov 22, 2023
aada502
chore(react): update snapshot
naporin0624 Nov 22, 2023
0036b15
chore: restore yarnlock
naporin0624 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@
"@charcoal-ui/theme": "^3.3.0-beta.0",
"@charcoal-ui/utils": "^3.3.0-beta.0",
"@react-aria/button": "^3.7.0",
"@react-aria/checkbox": "^3.8.0",
"@react-aria/checkbox": "^3.11.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isInvalid を受け入れるために version up

"@react-aria/dialog": "^3.5.0",
"@react-aria/focus": "^3.11.0",
"@react-aria/listbox": "^3.8.0",
"@react-aria/overlays": "^3.13.0",
"@react-aria/radio": "^3.5.0",
"@react-aria/radio": "^3.8.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-stately を上げたことで型の整合が取れなくなったので version up した

"@react-aria/select": "^3.9.0",
"@react-aria/separator": "^3.3.0",
"@react-aria/ssr": "^3.5.0",
Expand All @@ -71,7 +71,7 @@
"@react-aria/visually-hidden": "^3.7.0",
"polished": "^4.1.4",
"react-spring": "^9.0.0",
"react-stately": "^3.19.0",
"react-stately": "^3.26.0",
"warning": "^4.0.3"
},
"peerDependencies": {
Expand Down
Loading