Skip to content

Commit

Permalink
Merge pull request #677 from pixiv/mimo/v4-release-note
Browse files Browse the repository at this point in the history
docs: v4 release note
  • Loading branch information
yue4u authored Dec 18, 2024
2 parents 171d0bb + 0447d84 commit 543248e
Show file tree
Hide file tree
Showing 18 changed files with 159 additions and 67 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
options:
- latest
- beta
- rc

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ LICENSE
/packages/token-cli/tokens/
/packages/token-cli/out/
/packages/theme/src/unstable-css/
/packages/react/docs/v4.0.0.mdx
.storybook/src/v4.0.0.mdx
95 changes: 93 additions & 2 deletions packages/react/docs/v4.0.0.mdx → .storybook/src/v4.0.0.mdx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Meta, Story } from '@storybook/addon-docs'
import { Unstyled } from '@storybook/blocks'

<Meta title="react/docs/v4.0.0" />
<Meta title="v4.0.0" />

# @charcoal-ui/react@v4.0.0

Expand All @@ -22,6 +22,25 @@ function App() {
}
```

※ styled 廃止した影響で classname の優先度が変わるケースがあります。

```tsx
import { Button } from '@charcoal-ui/react'
import styled from 'styled-components'

// 今ままでと違う見た目になる可能性がある
const NewButton = styled(Button)`
color: red;
`
```

この場合 @layer 版の利用をおすすめしますが、サポート対象が iOS 15.4+ になります。

```diff
- import '@charcoal-ui/react/dist/index.css'
+ import '@charcoal-ui/react/dist/layered.css'
```

## ComponentAbstraction

- `ComponentAbstraction`が削除されました。
Expand Down Expand Up @@ -100,7 +119,6 @@ After

## MultiSelect

- コンポーネントが削除されました。
- `overlay`の代替として`Checkbox``rounded`が追加されました。

## RadioGroup
Expand All @@ -126,3 +144,76 @@ After

- `input`要素の`props`を継承するように変更しました。
- 文字数の計算ロジックを`getCount`プロパティで上書きできるように変更しました。

## その他

- `PixivIcon.extend` に渡す内容が sanitize されなくなります。必要な場合事前に sanitize するか、dompurify などを挟んでください [fix!(@charcoal-ui/icons): remove dompurify from v4. #643](https://github.com/pixiv/charcoal/pull/643)

# Design Token 2.0 の実験的サポート

## styled-components

実装例: [feat: token v2 demo styled #655](https://github.com/pixiv/charcoal/pull/655)

```ts
import React, { useState } from 'react'
import styled from 'styled-components'
import tokens from '@charcoal-ui/theme/unstable-tokens/css-variables.json'

const User = styled.a`
width: 40px;
height: 40px;
display: grid;
place-items: center;
border-radius: calc(${tokens.radius.oval} * 1px);
cursor: pointer;
color: ${tokens.color.icon.default};
background-color: ${tokens.color.container.secondary.default};
&:hover {
color: ${tokens.color.icon.hover};
background-color: ${tokens.color.container.secondary.hover};
}
&:active {
color: ${tokens.color.icon.press};
background-color: ${tokens.color.container.secondary.press};
}
`
```

## tailwindcss

実装例: [feat: allow design token v2 in tailwind config #650](https://github.com/pixiv/charcoal/pull/650)

```diff
const { light, dark } = require('@charcoal-ui/theme')
const {
createTailwindConfig,
} = require('@charcoal-ui/tailwind-config')

/**
* @type {import('tailwindcss/tailwind-config').TailwindConfig}
*/
module.exports = {
darkMode: false,
content: ['**/*.tsx'],
presets: [
createTailwindConfig({
version: 'v3',
theme: {
':root': light,
'[data-dark="true"]': dark,
},
+ unstableTokenV2: true,
}),
],
corePlugins: {
```

```html
<a
className="rounded-oval text-icon hover:text-icon-hover active:text-icon-press bg-container-secondary hover:bg-container-hover active:bg-container-press grid h-[40px] w-[40px] cursor-pointer place-items-center"
aria-label="UserIcon"
>
<Icon name="24/FaceEdit" />
</a>
```
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,5 @@
"packages": [
"packages/*"
],
"version": "4.0.0-beta.17"
"version": "4.0.0-rc.0"
}
2 changes: 1 addition & 1 deletion packages/esbuild-plugin-styled-components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/esbuild-plugin-styled-components",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"private": true,
"license": "Apache-2.0",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/foundation/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/foundation",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/icon-files/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/icon-files",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"type": "module",
"main": "./src/index.cjs",
Expand Down
2 changes: 1 addition & 1 deletion packages/icons-cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/icons-cli",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"bin": "./dist/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions packages/icons/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/icons",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand Down Expand Up @@ -36,7 +36,7 @@
"vitest": "^2.0.1"
},
"dependencies": {
"@charcoal-ui/icon-files": "^4.0.0-beta.17",
"@charcoal-ui/icon-files": "^4.0.0-rc.0",
"warning": "^4.0.3"
},
"files": [
Expand Down
14 changes: 7 additions & 7 deletions packages/react-sandbox/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/react-sandbox",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand All @@ -21,7 +21,7 @@
"test": "vitest run --passWithNoTests"
},
"devDependencies": {
"@charcoal-ui/esbuild-plugin-styled-components": "^4.0.0-beta.17",
"@charcoal-ui/esbuild-plugin-styled-components": "^4.0.0-rc.0",
"@storybook/addon-actions": "^7.4.1",
"@storybook/addon-knobs": "^7.0.2",
"@storybook/addons": "^7.4.1",
Expand Down Expand Up @@ -54,11 +54,11 @@
"vitest": "^2.0.2"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/react": "^4.0.0-beta.17",
"@charcoal-ui/styled": "^4.0.0-beta.17",
"@charcoal-ui/theme": "^4.0.0-beta.17",
"@charcoal-ui/utils": "^4.0.0-beta.17",
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"@charcoal-ui/react": "^4.0.0-rc.0",
"@charcoal-ui/styled": "^4.0.0-rc.0",
"@charcoal-ui/theme": "^4.0.0-rc.0",
"@charcoal-ui/utils": "^4.0.0-rc.0",
"polished": "^4.1.4",
"react-spring": "^9.0.0",
"warning": "^4.0.3"
Expand Down
12 changes: 6 additions & 6 deletions packages/react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/react",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand Down Expand Up @@ -33,7 +33,7 @@
"test": "vitest run --passWithNoTests"
},
"devDependencies": {
"@charcoal-ui/esbuild-plugin-styled-components": "^4.0.0-beta.17",
"@charcoal-ui/esbuild-plugin-styled-components": "^4.0.0-rc.0",
"@react-types/switch": "^3.1.2",
"@storybook/addon-actions": "^8.0.5",
"@storybook/react": "^8.0.5",
Expand Down Expand Up @@ -62,10 +62,10 @@
"vitest": "^2.0.1"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/icons": "^4.0.0-beta.17",
"@charcoal-ui/theme": "^4.0.0-beta.17",
"@charcoal-ui/utils": "^4.0.0-beta.17",
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"@charcoal-ui/icons": "^4.0.0-rc.0",
"@charcoal-ui/theme": "^4.0.0-rc.0",
"@charcoal-ui/utils": "^4.0.0-rc.0",
"@react-aria/button": "^3.9.1",
"@react-aria/checkbox": "^3.13.0",
"@react-aria/dialog": "^3.5.10",
Expand Down
8 changes: 4 additions & 4 deletions packages/styled/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/styled",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"types": "./dist/index.d.ts",
"main": "./dist/index.cjs.js",
Expand Down Expand Up @@ -38,9 +38,9 @@
"vitest": "^2.0.2"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/theme": "^4.0.0-beta.17",
"@charcoal-ui/utils": "^4.0.0-beta.17",
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"@charcoal-ui/theme": "^4.0.0-rc.0",
"@charcoal-ui/utils": "^4.0.0-rc.0",
"warning": "^4.0.3"
},
"peerDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions packages/tailwind-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/tailwind-config",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand Down Expand Up @@ -32,9 +32,9 @@
"vitest": "^2.0.2"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/theme": "^4.0.0-beta.17",
"@charcoal-ui/utils": "^4.0.0-beta.17"
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"@charcoal-ui/theme": "^4.0.0-rc.0",
"@charcoal-ui/utils": "^4.0.0-rc.0"
},
"peerDependencies": {
"csstype": ">=3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/tailwind-diff/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/tailwind-diff",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"bin": "bin/tailwind-diff.js",
"scripts": {
"build": "tsc",
Expand Down
6 changes: 3 additions & 3 deletions packages/theme/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/theme",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand Down Expand Up @@ -63,8 +63,8 @@
"vitest": "^2.0.2"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/utils": "^4.0.0-beta.17",
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"@charcoal-ui/utils": "^4.0.0-rc.0",
"change-case-all": "^2.1.0",
"deepmerge": "^4.3.1",
"polished": "^4.1.4"
Expand Down
2 changes: 1 addition & 1 deletion packages/token-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"bin": "./dist/index.js",
"type": "commonjs",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"scripts": {
"build": "FORCE_COLOR=1 tsup-node",
Expand Down
4 changes: 2 additions & 2 deletions packages/utils/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@charcoal-ui/utils",
"version": "4.0.0-beta.17",
"version": "4.0.0-rc.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"module": "./dist/index.esm.js",
Expand All @@ -26,7 +26,7 @@
"vitest": "^2.0.2"
},
"dependencies": {
"@charcoal-ui/foundation": "^4.0.0-beta.17",
"@charcoal-ui/foundation": "^4.0.0-rc.0",
"polished": "^4.1.4"
},
"files": [
Expand Down
Loading

0 comments on commit 543248e

Please sign in to comment.