pull public ips from aws-cli and not /latest/meta-data #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhouseknecht
commented
Aug 30, 2022
| @@ -181,6 +181,7 @@ def info | |||
| raise Errors::MetaBadResponse unless Meta.interface(hwaddr, '', not_found: nil) | |||
| { | |||
| hwaddr: hwaddr, | |||
| instance_id: Meta.instance('instance-id'), | |||
There was a problem hiding this comment.
It was easier to just add this to the info's metadata than trying to pull it from lib/aws-eni.rb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At some point in the recent past, the
/latest/meta-data/.../ipv4-associations/{private-ip}endpoint started bunching up all public IPs to one private IP. In the AWS console, the public IPs were still mapped to the correct private IPs. This bug/feature from the endpoint caused the mappings to break since aws-eni thought that only one private IP had a public IP assigned even though multiple private IPs could have had public IPs associated.Resolution
Instead of hitting
/meta-data/...endpoints to query for public IPs, this PR will start usingaws ec2 describe-addressesto fetch the actual private/public IP mappings for a given ENI.