Use proper finding IDs for sonar and semgrep SARIF

pixee · Jan 9, 2025 · 3999240 · 3999240
1 parent 3b74eb9
commit 3999240
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/codemodder/result.py b/src/codemodder/result.py
@@ -105,6 +105,7 @@ def from_sarif(
         )
 
     @classmethod
+    @abstractmethod
     def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:
         raise NotImplementedError
 

diff --git a/src/core_codemods/sonar/results.py b/src/core_codemods/sonar/results.py
@@ -69,7 +69,7 @@ def from_result(cls, result: dict) -> Self:
             locations=locations,
             codeflows=all_flows,
             finding=Finding(
-                id=rule_id,
+                id=finding_id,
                 rule=Rule(
                     id=rule_id,
                     name=name,