Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all flake8 errors #183

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Fix all flake8 errors #183

merged 3 commits into from
Jun 29, 2024

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Jun 16, 2024 •
edited
Loading

Fix all flake8 errors in our GH Actions workflow runs (see this recent one for an example)

(Yeah, I mistyped; the first commit below should say "flake8", not "mypy")

@tianyizheng02
Copy link
Contributor Author

All flake8 errors have been fixed:

0
0

@tianyizheng02 tianyizheng02 marked this pull request as ready for review June 16, 2024 10:52
@tianyizheng02 tianyizheng02 requested a review from nij-patel June 16, 2024 10:53
@tianyizheng02 tianyizheng02 changed the title Fix all mypy errors Fix all flake8 errors Jun 16, 2024
@nij-patel
Copy link
Member

LGTM

@tianyizheng02 tianyizheng02 merged commit 82ea781 into dev Jun 29, 2024
4 checks passed
@tianyizheng02 tianyizheng02 deleted the fix-flake8-errs branch June 29, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nij-patel nij-patel nij-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @nij-patel