New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel_pipeline: fix system frames again #820

Merged

aconchillo merged 1 commit into main from aleix/more-parallelpipeline-fixes

Dec 11, 2024

Contributor

aconchillo commented Dec 11, 2024

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

The other fix was not correct after all. We now do the following:

Once ParallelPipeline receives a system frame it will create one task per internal pipeline. The internal pipeline will process the system frame in a single task (which is the newly created one).
Once all the internal pipelines have processed the system frame we now push it downstream from the original task.


          parallel_pipeline: fix system frames again

7b6bbc2

aconchillo requested review from markbackman and kwindla

December 11, 2024 02:15

markbackman approved these changes

View reviewed changes

aconchillo merged commit 4f9a4eb into main

3 checks passed

aconchillo deleted the aleix/more-parallelpipeline-fixes branch

December 11, 2024 02:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet