Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calls to flush_audio for say() and rtvi action #492

Merged
merged 2 commits into from
Sep 25, 2024
Merged

add calls to flush_audio for say() and rtvi action #492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3621fce
fixes as noted by aleix
kwindla Sep 25, 2024
3d43ad0
actually save the file
kwindla Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/pipecat/services/ai_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ def __init__(
async def flush_audio(self):
pass

async def say(self, text: str):
await super.say(text)
await self.flush_audio()

async def start(self, frame: StartFrame):
await super().start(frame)
if self._push_stop_frames:
Expand All @@ -278,6 +282,11 @@ async def cancel(self, frame: CancelFrame):
await self._stop_frame_task
self._stop_frame_task = None

async def process_frame(self, frame: Frame, direction: FrameDirection):
super().process_frame(frame, direction)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still missing the await here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Egads. Sorry. I clearly do not know how to use computers.

if isinstance(frame, TTSSpeakFrame):
await self.flush_audio()

async def push_frame(self, frame: Frame, direction: FrameDirection = FrameDirection.DOWNSTREAM):
await super().push_frame(frame, direction)

Expand Down
Loading