Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce input/output audio and image frames #480

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

aconchillo
Copy link
Contributor

No description provided.

@aconchillo aconchillo requested a review from kwindla September 20, 2024 02:32
@aconchillo aconchillo marked this pull request as draft September 20, 2024 02:32
@aconchillo aconchillo force-pushed the aleix/input-output-frames branch from d654208 to 116e690 Compare September 20, 2024 05:46
@aconchillo aconchillo marked this pull request as ready for review September 20, 2024 05:46
We now distinguish between input and output audio and image frames. We introduce
`InputAudioRawFrame`, `OutputAudioRawFrame`, `InputImageRawFrame` and
`OutputImageRawFrame` (and other subclasses of those). The input frames usually
come from an input transport and are meant to be processed inside the pipeline
to generate new frames. However, the input frames will not be sent through an
output transport. The output frames can also be processed by any frame processor
in the pipeline and they are allowed to be sent by the output transport.
@aconchillo aconchillo force-pushed the aleix/input-output-frames branch from 116e690 to 7e39d9a Compare September 20, 2024 06:11
@chadbailey59
Copy link
Contributor

tldr

Copy link
Contributor

@kwindla kwindla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aconchillo aconchillo merged commit 14acf05 into main Sep 20, 2024
3 checks passed
@aconchillo aconchillo deleted the aleix/input-output-frames branch October 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants