Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rfc for the livestate feature #5448

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Dec 24, 2024

What this PR does:

as title

Why we need it:

Which issue(s) this PR fixes:

Part of #5363

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.22%. Comparing base (511ee8f) to head (aaeb9ee).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5448      +/-   ##
==========================================
+ Coverage   26.09%   26.22%   +0.13%     
==========================================
  Files         451      452       +1     
  Lines       48824    48872      +48     
==========================================
+ Hits        12741    12819      +78     
+ Misses      35065    35027      -38     
- Partials     1018     1026       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo enabled auto-merge (squash) December 25, 2024 01:22
@ffjlabo ffjlabo merged commit b0df29e into master Dec 25, 2024
18 checks passed
@ffjlabo ffjlabo deleted the update-rfc-for-livestate branch December 25, 2024 01:35
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants