Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude go: downloading lines from go test #186

Closed
wants to merge 1 commit into from
Closed

Exclude go: downloading lines from go test #186

wants to merge 1 commit into from

Conversation

Sean-Der
Copy link
Member

@codecov
Copy link

codecov bot commented May 22, 2022 •
edited
Loading

Codecov Report

Merging #186 (51b8888) into master (fc65bfa) will not change coverage.
The diff coverage is n/a.

❗ Current head 51b8888 differs from pull request most recent head c4cc145. Consider uploading reports for the commit c4cc145 to get more accurate results

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          29       29           
  Lines        2643     2643           
=======================================
  Hits         2228     2228           
  Misses        311      311           
  Partials      104      104
Flag Coverage Δ
go 84.17% <ø> (-0.12%) ⬇️
wasm 77.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc65bfa...c4cc145. Read the comment docs.

@Sean-Der Sean-Der force-pushed the gotestfmt branch 2 times, most recently from 82ae4e4 to 51b8888 Compare May 22, 2022 17:43
adriancable
adriancable approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@adriancable adriancable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a weird 'bug' / side effect of go-acc.

@Sean-Der
Copy link
Member Author

@adriancable yea that was a fun one

@Sean-Der Sean-Der closed this May 23, 2022
@Sean-Der Sean-Der deleted the gotestfmt branch May 23, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriancable adriancable adriancable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sean-Der @adriancable