Expose protocol to get image data from the cache plus WebP cleanup #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently we made several headers private in Cocoapods. However, some clients were reaching directly into PINRemoteImage's memory cache (PINCache) and pulling out
PINRemoteImageMemoryContainer
and doing whatever with it. To support that use case without exposing more than necessary publicly, introduce thePINRemoteImageDataConvertible
protocol and havePINRemoteImageMemoryContainer
conform to it.So if previously the code was:
it can be
Also, previous changes required
PIN_WEBP
to be defined in the project settings or it would fail to compile. That's been changed to always build. If not specified it will default to1
.Test plan
Run
make all
to run tests and build everything