Support Building from Xcode 15 #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Currently, PINRemoteImage does not build with recent build tools. We should fix that, plus update all the dependencies. This bumps min versions of iOS and tvOS up to 14.0, and macOS to 11.0. This allows us to drop the `libwebp` dependency, which is not currently building with recent tools either, and instead use the system provided decoder. **This does mean tvOS loses support for WebP as tvOS doesn't have a system decoder.** Also, clean up the headers. Cocoapods was including way too much as public headers, and we were using double quotes instead of angle brackets for them. ## Test plan Make sure everything builds & unit tests pass. Also, update all the examples and ensure they work.
|
cc @tstump-phunware |
|
Is this planned to be in any release soon? |
|
Hi @jaichaudhry . Yes, this got released with 3.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, PINRemoteImage does not build with recent build tools. We should fix that, plus update all the dependencies.
This bumps min versions of iOS and tvOS up to 14.0, and macOS to 11.0. This allows us to drop the
libwebpdependency, which is not currently building with recent tools either, and instead use the system provided decoder. This does mean tvOS loses support for WebP as tvOS doesn't have a system decoder.Also, clean up the headers. Cocoapods was including way too much as public headers, and we were using double quotes instead of angle brackets for them.
Test plan
Make sure everything builds & unit tests pass. Also, update all the examples and ensure they work.