Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: add warning for deletion of data dir #2481

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Dec 15, 2024

Signed-off-by: xhe [email protected]

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
TiDB Playground Cluster will delete all data after exit. Please use --tag xx to pin the data dir.

🎉 TiDB Playground Cluster is started, enjoy!

Connect TiDB:    mysql --host 127.0.0.1 --port 4000 -u root
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@xhebox xhebox requested a review from bb7133 December 15, 2024 16:07
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xhebox, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from nexustar December 15, 2024 16:07
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2024
Signed-off-by: xhe <[email protected]>
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 16, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 08:22:51.990402029 +0000 UTC m=+858762.079204572: ☑️ agreed by bb7133.
  • 2024-12-16 11:01:14.307848385 +0000 UTC m=+868264.396650928: ✖️🔁 reset by xhebox.
  • 2024-12-20 06:44:15.659429619 +0000 UTC m=+1198445.748232159: ☑️ agreed by kaaaaaaang.

@xhebox xhebox merged commit bc0e4a9 into pingcap:master Dec 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants