Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Add --dry-run for preparing binaries in CI #2478

Closed
wants to merge 1 commit into from

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Sometimes we want to prepare binaries but do not run them. For example, we may want to prepare the binaries in a Docker build step, so that when image is used later (like in CI) there will be no repeated downloads.

What is changed and how it works?

This PR introduce --dry-run exactly for this kind of purpose.

When playground is called with --dry-run, everything will be as usual except that no instance will be run actually, and TiUP playground will stop immediately after everything is prepared.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
$ bin/tiup-playground nightly --dry-run
The component `pd` version v8.5.0-alpha-nightly is not installed; downloading from repository.
download ...
Start pd instance: v8.5.0-alpha-nightly
The component `tikv` version v8.5.0-alpha-nightly is not installed; downloading from repository.
download ...
Start tikv instance: v8.5.0-alpha-nightly
The component `tidb` version v8.5.0-alpha-nightly is not installed; downloading from repository.
download ..
Start tidb instance: v8.5.0-alpha-nightly
The component `prometheus` version v8.5.0-alpha-nightly is not installed; downloading from repository.
download ...
The component `tiflash` version v8.5.0-alpha-nightly is not installed; downloading from repository.
download ...
Start tiflash instance: v8.5.0-alpha-nightly
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and nexustar December 4, 2024 11:26
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2024
@breezewish breezewish closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant