-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: polish the trust key notice #2475
Conversation
Signed-off-by: Wish <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Wish <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
- Coverage 54.86% 48.50% -6.35%
==========================================
Files 336 335 -1
Lines 36372 36360 -12
==========================================
- Hits 19953 17636 -2317
- Misses 14014 16397 +2383
+ Partials 2405 2327 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install test will be fixed after merging
What problem does this PR solve?
Currently when installing TiUP, a misleading warning will be displayed:
What is changed and how it works?
Only display the warning, when JSON is accessed via insecure Internet.
And also carefully polished the words, to avoid being mis-interpreted as System root certificate.
Check List
Tests
Release notes: