Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: polish the trust key notice #2475

Merged
merged 2 commits into from
Nov 15, 2024
Merged

*: polish the trust key notice #2475

merged 2 commits into from
Nov 15, 2024

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Currently when installing TiUP, a misleading warning will be displayed:

image

What is changed and how it works?

Only display the warning, when JSON is accessed via insecure Internet.

And also carefully polished the words, to avoid being mis-interpreted as System root certificate.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack November 12, 2024 06:40
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.50%. Comparing base (505444d) to head (faf277c).
Report is 2 commits behind head on master.

Current head faf277c differs from pull request most recent head 3856938

Please upload reports for the commit 3856938 to get more accurate results.

Files with missing lines Patch % Lines
pkg/localdata/profile.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (505444d) and HEAD (faf277c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (505444d) HEAD (faf277c)
unittest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
- Coverage   54.86%   48.50%   -6.35%     
==========================================
  Files         336      335       -1     
  Lines       36372    36360      -12     
==========================================
- Hits        19953    17636    -2317     
- Misses      14014    16397    +2383     
+ Partials     2405     2327      -78     
Flag Coverage Δ
cluster 42.74% <0.00%> (-2.00%) ⬇️
playground 16.13% <50.00%> (+0.02%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 10:13:36.221995929 +0000 UTC m=+437578.412864919: ☑️ agreed by kaaaaaaang.

Copy link
Collaborator

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install test will be fixed after merging

@xhebox xhebox merged commit 9771000 into master Nov 15, 2024
20 of 22 checks passed
@xhebox xhebox deleted the wenxuan/fix-note branch November 15, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants