Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cdc server topylogy example #2466

Merged
merged 2 commits into from
Nov 5, 2024
Merged

add cdc server topylogy example #2466

merged 2 commits into from
Nov 5, 2024

Conversation

wk989898
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

As title.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and nexustar October 29, 2024 07:15
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 29, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wk989898
Copy link
Contributor Author

/retest

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-31 04:20:00.745143988 +0000 UTC m=+496313.584299548: ☑️ agreed by kaaaaaaang.
  • 2024-10-31 06:33:36.659412475 +0000 UTC m=+504329.498568021: ✖️🔁 reset by wk989898.
  • 2024-11-05 03:40:49.807847052 +0000 UTC m=+925962.647002598: ☑️ agreed by xhebox.

@xhebox xhebox merged commit b53edf7 into pingcap:master Nov 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants