Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: support scaling ms instances when using playground #2417

Merged
merged 2 commits into from
May 13, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 8, 2024

What problem does this PR solve?

close #2418

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:23:04]
$ bin/tiup-playground scale-out --tso 1

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:23:56]
$ bin/tiup-playground display
Pid      Role        Uptime
---      ----        ------
1664279  pd          50.760217075s
1664294  tso         50.047913364s
1668333  tso         5.790315547s
1664307  scheduling  49.294502817s
1664365  tikv        43.760522609s
1664865  tidb        43.38240817s
1665074  tiflash     34.235445093s

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:24:02]
$ bin/tiup-playground scale-in --pid 1664294
scale in tso success

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:24:11]
$ bin/tiup-playground display
Pid      Role        Uptime
---      ----        ------
1664279  pd          1m4.192541288s
1668333  tso         19.222638732s
1664307  scheduling  1m2.726825553s
1664365  tikv        57.192846277s
1664865  tidb        56.814730897s
1665074  tiflash     47.667768248s

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack May 8, 2024 06:25
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label May 9, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label May 13, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label May 13, 2024
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.14%. Comparing base (50abc4f) to head (70b6f30).

❗ Current head 70b6f30 differs from pull request most recent head 09852d8. Consider uploading reports for the commit 09852d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2417   +/-   ##
=======================================
  Coverage   50.14%   50.14%           
=======================================
  Files         333      333           
  Lines       35867    35866    -1     
=======================================
  Hits        17984    17984           
+ Misses      15521    15520    -1     
  Partials     2362     2362           
Flag Coverage Δ
tiup 33.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label May 13, 2024
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 07:25:53.380045768 +0000 UTC m=+1119707.137181336: ☑️ agreed by kaaaaaaang.
  • 2024-05-13 05:32:47.73345497 +0000 UTC m=+1458521.490590543: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-05-13 17:28:45.610124908 +0000 UTC m=+1501479.367260488: ☑️ agreed by kaaaaaaang.

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 282aff0 into pingcap:master May 13, 2024
6 of 7 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.16.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdms:tiup playground should support scale-out new component including tso and scheduling
3 participants