Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix the health check #2415

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 7, 2024

What problem does this PR solve?

close #2416.

What is changed and how it works?

Check List

Tests

  • Manual test

Release notes:

NONE

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack May 7, 2024 10:25
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.99%. Comparing base (42d1df3) to head (444cda9).

❗ Current head 444cda9 differs from pull request most recent head 4cafd01. Consider uploading reports for the commit 4cafd01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
- Coverage   55.18%   47.99%   -7.19%     
==========================================
  Files         334      333       -1     
  Lines       35882    35869      -13     
==========================================
- Hits        19799    17213    -2586     
- Misses      13706    16390    +2684     
+ Partials     2377     2266     -111     
Flag Coverage Δ
tiup 33.76% <ø> (+0.05%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ryan Leung <[email protected]>
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label May 9, 2024
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 07:26:08.872381799 +0000 UTC m=+1119722.629517370: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 50abc4f into pingcap:master May 13, 2024
18 of 19 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.16.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdms: tiup playground can't startup tikv
4 participants