Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpp cmakefile incorrect file path issue #350

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Dec 18, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
In #347, generate-cpp.sh path is changed, the CMakefile under cpp dir should be updated also.
Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yibin87 yibin87 merged commit 8408c76 into pingcap:master Dec 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants