Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/p2p(cdc,dataflow): Make it safe to write to the same topic concurrently #4808

Merged
merged 3 commits into from
Mar 8, 2022
Merged

pkg/p2p(cdc,dataflow): Make it safe to write to the same topic concurrently #4808

merged 3 commits into from
Mar 8, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Mar 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref microcosm#211

What is changed and how it works?

  • Make it safe for multiple goroutines to send to the same message topic.

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 8, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Mar 8, 2022

/run-leak-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 8, 2022
@liuzix liuzix changed the title [WIP] pkg/p2p(cdc,dataflow): Make it safe to write to the same topic concurrently pkg/p2p(cdc,dataflow): Make it safe to write to the same topic concurrently Mar 8, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2022
@liuzix liuzix requested a review from amyangfei March 8, 2022 08:56
@liuzix liuzix mentioned this pull request Mar 8, 2022
Open
2 tasks
@liuzix liuzix merged commit e342c02 into pingcap:dfe-dep Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuzix @ti-chi-bot