*: only enable new string serdes format in exchange when MppVersion >= MppVersionV3 #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
|
PR of tidb is pingcap/tidb#58652. Merge this PR before merging the PR of tidb. |
13 tasks
JinheLin
changed the title
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
bot
added
size/L
|
@windtalker PTAL |
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
size/XL
|
/retest |
JinheLin
changed the title
windtalker
reviewed
Jan 9, 2025
| case MppVersion::MppVersionV3: | ||
| return MPPDataPacketVersion::MPPDataPacketV2; | ||
| default: |
There was a problem hiding this comment.
why make MPPDataPacketV1 as the default value? If there is MppVersionV4, will it use MPPDataPacketV1?
There was a problem hiding this comment.
I used to follow the code of
auto data_codec_version = mpp_version == MppVersionV0 ? MPPDataPacketV0 : MPPDataPacketV1;
Its default value is MPPDataPacketV1.
But I have just updated the code to make MPPDataPacketV2 as the default value now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9673
Problem Summary:
What is changed and how it works?
tidb will send an
MppVersionfield to tiflash.When rolling upgrade, tiflash will be upgraded before tidb.
During the process of upgrading tiflash, tidb has not been upgraded yet, so all mpp versions received are
MppVersionsV2, tiflash still using the old format to exchange data.When upgrading tidb, the new tidb uses
MppVersionsV3to send requests, and tiflash starts using the new format to exchange data (at this point, all tiflash has been upgraded, so there will be no compatibility issues).PR of tidb is copr: add MppVersionV3 tidb#58652.
Check List
Tests
Side effects
Documentation
Release note