Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proxy of master to raftstore-proxy for memory purge and memory status #9721

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 11, 2024

What problem does this PR solve?

Issue Number: ref #4982 ref #9722

Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy b877a97699..50b8d2e0fa:

Support arena.i.purge and malloc_stats_print when jemalloc is used (#402)

It is the first part of #9707

What is changed and how it works?

- Provide an http interface "/debug/pprof/arena_purge" for purging the dirty/muzzy page in jemalloc. This could help reduce the memory consumption after large txn is committed.
    Reference: https://jemalloc.net/jemalloc.3.html#opt.muzzy_decay_ms
- Provide an http interface "/debug/pprof/memory_status" to get memory allocation information is using jemalloc. Note that the return result may take dozens MiB.

image

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2024
@CalvinNeo CalvinNeo changed the title update proxy of master to raftstore-proxy update proxy of master to raftstore-proxy for memory purge and memory status Dec 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 08:17:41.746103359 +0000 UTC m=+426451.834905897: ☑️ agreed by JaySon-Huang.
  • 2024-12-11 09:02:43.148457189 +0000 UTC m=+429153.237259733: ☑️ agreed by Lloyd-Pottiger.

Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 96ae6d2 into pingcap:master Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants