Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix substring wrong result bug #9603

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix substring wrong result bug #9603

merged 3 commits into from
Nov 14, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Nov 12, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9604

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix substring wrong result when the second argument is negative

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Nov 12, 2024
@guo-shaoge
fix case
3bdf839 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Contributor Author

/run-pull-integration-test

yibin87
yibin87 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
windtalker
windtalker approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 01:59:45.101935123 +0000 UTC m=+494347.292804120: ☑️ agreed by yibin87.
  • 2024-11-14 05:23:37.536233765 +0000 UTC m=+506579.727102763: ☑️ agreed by windtalker.

@guo-shaoge
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c140fa4 into pingcap:master Nov 14, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_substring_bug branch November 14, 2024 07:18
@JaySon-Huang
Copy link
Contributor

@guo-shaoge I think we should add "release note" for this bug-fix PR

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 14, 2024
@guo-shaoge guo-shaoge mentioned this pull request Nov 15, 2024
Closed
@guo-shaoge
Copy link
Contributor Author

/run-cherry-picker

@guo-shaoge guo-shaoge added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9617.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9618.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9619.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Open
12 tasks
@guo-shaoge guo-shaoge added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9620.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9621.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9622.

This was referenced Nov 15, 2024
Merged
Merged
Merged
ti-chi-bot bot added a commit that referenced this pull request Nov 18, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix substring wrong result bug (#9603) (#9618)
4e66879 
close #9604

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @guo-shaoge
fix substring wrong result bug (#9603) (#9617)
30683ef 
close #9604

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
ti-chi-bot bot added a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix substring wrong result bug (#9603) (#9620)
ccd273a 
close #9604

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix substring wrong result bug (#9603) (#9621)
6e69793 
close #9604

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
@ti-chi-bot @guo-shaoge @JaySon-Huang
fix substring wrong result bug (#9603) (#9622)
a95bef8 
close #9604

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: JaySon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong result of substring when the second argument of substring is negative
5 participants
@guo-shaoge @JaySon-Huang @ti-chi-bot @windtalker @yibin87