Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update client-go and verify all read ts #58925

Open
wants to merge 2 commits into
base: release-7.5
Choose a base branch
from

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jan 14, 2025

What problem does this PR solve?

Issue Number: ref #57786

Problem Summary:

What changed and how does it work?

Cherry pick #58054

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Strengthen timestamp validation checks.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Jan 14, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 14, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 14, 2025

Waiting for tikv/client-go#1548

@ekexium ekexium force-pushed the release-7.5-validate-ts branch from a14bc6c to 2e19b63 Compare January 15, 2025 03:17
@ekexium ekexium force-pushed the release-7.5-validate-ts branch from 2e19b63 to 9f34f2e Compare January 15, 2025 09:18
Copy link

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign winoros for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 15, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 15, 2025

/retest

Copy link

ti-chi-bot bot commented Jan 15, 2025

@ekexium: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 9f34f2e link true /test build
idc-jenkins-ci-tidb/unit-test 9f34f2e link true /test unit-test
idc-jenkins-ci-tidb/check_dev 9f34f2e link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 9f34f2e link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants