-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/lightning: support pd_enable_follower_handle_region #58653
br/lightning: support pd_enable_follower_handle_region #58653
Conversation
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58653 +/- ##
================================================
+ Coverage 73.1093% 75.2504% +2.1410%
================================================
Files 1676 1722 +46
Lines 463369 475543 +12174
================================================
+ Hits 338766 357848 +19082
+ Misses 103786 95424 -8362
- Partials 20817 22271 +1454
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: okJiang <[email protected]>
/retest |
can you provide some information about the behaviour? for example, will the follower returns the latest information like a TiDB follower read? Please also add this description in the comment of |
The followers exist a slight delay compared to the PD leader, and they synchronize region data through a syncer. Therefore, followers may not necessarily return the latest information. I have checked all the modified requests, and they should all have a retry mechanism, as the PD leader cannot guarantee that the region information is up to date. Whatever, from the actual effect of enabling
WithAllowFollowerHandle is a client switch. It takes effect in combination with |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #58651
Problem Summary:
After this pr, if tidb enables
pd_enable_follower_handle_region
, BR/ lightning will also benefit from this parameter and sendScanRegions/GetRegion
to PD follower/leader distributively.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.