-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix flaky test TestGCServiceSafePoint #58628
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Wenqi Mou <[email protected]>
08d5dd2
to
74a7855
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58628 +/- ##
================================================
+ Coverage 73.5455% 74.7687% +1.2232%
================================================
Files 1680 1695 +15
Lines 464730 466129 +1399
================================================
+ Hits 341788 348519 +6731
+ Misses 102118 96047 -6071
- Partials 20824 21563 +739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/assign @YuJuncen |
What problem does this PR solve?
Issue Number: close #58627
Problem Summary:
What changed and how does it work?
test will fail if when try to advance the new TS is less now hardcoded 5, make it 1 so less likely to fail.
Tried to make it 0 but a bunch of tests failed, don't know why.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.