-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix go leak when nothing to restore #58626
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -1041,7 +1046,6 @@ func runSnapshotRestore(c context.Context, mgr *conn.Mgr, g glue.Glue, cmdName s | |||
|
|||
if len(files) == 0 { | |||
log.Info("no files, empty databases and tables are restored") | |||
summary.SetSuccessStatus(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should go though to the end of method and get set anyway
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58626 +/- ##
================================================
+ Coverage 73.5455% 74.7942% +1.2487%
================================================
Files 1680 1695 +15
Lines 464730 466857 +2127
================================================
+ Hits 341788 349182 +7394
+ Misses 102118 96094 -6024
- Partials 20824 21581 +757
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wenqi Mou <[email protected]>
/assign @3pointer |
What problem does this PR solve?
Issue Number: close #58624
Problem Summary:
What changed and how does it work?
recent change makes the ctx in GoSwitchToImportMode not inherit from the main ctx, thus when main ctx cancelled the go routine didn't return, and the manual cleanup logic wasn't called when nothing to return either, leading to a go routine leak found in int test
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.