Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Fix arg validation for tidb_mvcc_info() #58310

Merged
merged 4 commits into from
Dec 19, 2024
Merged

expression: Fix arg validation for tidb_mvcc_info() #58310

merged 4 commits into from
Dec 19, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58309

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

A situation where the connection was dropped when TIDB_MVCC_INFO() was called without arguments was fixed.

Related

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 16, 2024

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Dec 16, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 16, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7502%. Comparing base (0be1983) to head (48504c5).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58310        +/-   ##
================================================
+ Coverage   73.1936%   73.7502%   +0.5566%     
================================================
  Files          1681       1681                
  Lines        463050     463974       +924     
================================================
+ Hits         338923     342182      +3259     
+ Misses       103344     101039      -2305     
+ Partials      20783      20753        -30
Flag Coverage Δ
integration 43.1656% <100.0000%> (?)
unit 72.3674% <0.0000%> (+0.0477%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0230% <ø> (+0.0030%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 17, 2024
D3Hunter
D3Hunter reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/parser/parser_test.go
@@ -1693,7 +1693,6 @@ func TestBuiltin(t *testing.T) {
{`SELECT tidb_decode_key('abc');`, true, "SELECT TIDB_DECODE_KEY(_UTF8MB4'abc')"},
{`SELECT tidb_decode_base64_key('abc');`, true, "SELECT TIDB_DECODE_BASE64_KEY(_UTF8MB4'abc')"},
{`SELECT tidb_decode_sql_digests('[]');`, true, "SELECT TIDB_DECODE_SQL_DIGESTS(_UTF8MB4'[]')"},
{`SELECT get_mvcc_info('hex', '0xabc');`, true, "SELECT GET_MVCC_INFO(_UTF8MB4'hex', _UTF8MB4'0xabc')"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIDB_MVCC_INFO() works, GET_MVCC_INFO() does not and seems to be a half renamed or half implemented thing.

mjonss
mjonss approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any way to have a test for this change?

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 02:40:30.881281192 +0000 UTC m=+924620.970083730: ☑️ agreed by Defined2014.
  • 2024-12-17 15:45:19.279834862 +0000 UTC m=+971709.368637390: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Dec 18, 2024

Are there any way to have a test for this change?

Done in 48504c5

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Defined2014, mjonss, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85f3f9c into pingcap:master Dec 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@mjonss mjonss mjonss approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connection running loop panic: select tidb_mvcc_info()
5 participants
@dveeden @D3Hunter @mjonss @XuHuaiyu @Defined2014