Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update client-go #51953

Closed
wants to merge 2 commits into from
Closed

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Mar 20, 2024

What problem does this PR solve?

Issue Number: close #49353

Problem Summary:
See #49353 and tikv/client-go#1239.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: gengliqi <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
Copy link

tiprow bot commented Mar 20, 2024

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 20, 2024
@hawkingrei
Copy link
Member

/retest

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Signed-off-by: gengliqi <[email protected]>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #51953 (dd5560a) into master (d940619) will decrease coverage by 15.8834%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51953         +/-   ##
=================================================
- Coverage   70.6700%   54.7866%   -15.8834%     
=================================================
  Files          1477       1588        +111     
  Lines        438718     610015     +171297     
=================================================
+ Hits         310042     334207      +24165     
- Misses       109176     252599     +143423     
- Partials      19500      23209       +3709     
Flag Coverage Δ
integration 36.5858% <ø> (?)
unit 70.4618% <ø> (+0.0012%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3868% <ø> (+5.5824%) ⬆️

Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 09:40:24.062171975 +0000 UTC m=+1456051.084418363: ☑️ agreed by windtalker.
  • 2024-03-20 10:17:44.224056292 +0000 UTC m=+1458291.246302681: ☑️ agreed by SeaRise.

@gengliqi
Copy link
Contributor Author

/retest

1 similar comment
@gengliqi
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 20, 2024

@gengliqi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow dd5560a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gengliqi
Copy link
Contributor Author

Another PR has updated client-go

@gengliqi gengliqi closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default flow control strategy is not very memory friendly for a cluster with many TiFlash nodes
4 participants