-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-go: fix data race that may cause tikv/client-go client_batch panic #51729
Conversation
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51729 +/- ##
================================================
+ Coverage 72.1248% 73.3282% +1.2034%
================================================
Files 1467 1468 +1
Lines 426605 433485 +6880
================================================
+ Hits 307688 317867 +10179
+ Misses 99728 95808 -3920
- Partials 19189 19810 +621
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: crazycs520 <[email protected]>
9ff9e58
to
202dea8
Compare
Signed-off-by: crazycs520 <[email protected]>
/retest |
@zyguan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #39169
Problem Summary: See tikv/client-go#1219
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.