-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move util into pkg/util #47158
*: move util into pkg/util #47158
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Hi @lcwangchao. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47158 +/- ##
================================================
- Coverage 73.0051% 72.6586% -0.3466%
================================================
Files 1338 1359 +21
Lines 399462 405751 +6289
================================================
+ Hits 291628 294813 +3185
- Misses 88992 92198 +3206
+ Partials 18842 18740 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
2824006
to
325a917
Compare
3087aca
to
08e6150
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[LGTM Timeline notifier]Timeline:
|
/approve There is no sysvar change. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: easonn7, hawkingrei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
close for #47123 will include this change |
What problem does this PR solve?
Issue Number: ref #41241
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.