Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add UT for PD/TiKV/TiDB/TiFlash APIs #6012

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.55%. Comparing base (749fbbb) to head (5150ebb).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6012      +/-   ##
==============================================
+ Coverage       24.50%   27.55%   +3.04%     
==============================================
  Files             151      151              
  Lines            9912     9912              
==============================================
+ Hits             2429     2731     +302     
+ Misses           7294     6932     -362     
- Partials          189      249      +60     
Flag Coverage Δ
unittest 27.55% <100.00%> (+3.04%) ⬆️

Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 5244f35 into pingcap:feature/v2 Dec 26, 2024
6 of 7 checks passed
@csuzhangxc csuzhangxc deleted the ut2 branch December 26, 2024 07:53
@liubog2008 liubog2008 added the v2 for operator v2 label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants