feat(pdgroup): migrate to task v3 #6011
Conversation
liubog2008
commented
Dec 26, 2024
•
liubog2008
commented
- use task v3 to org tasks of pd group
- refactor status task
- support currentReplicas and updateReplicas
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6011 +/- ##
==============================================
+ Coverage 24.50% 31.91% +7.40%
==============================================
Files 151 153 +2
Lines 9912 9945 +33
==============================================
+ Hits 2429 3174 +745
+ Misses 7294 6517 -777
- Partials 189 254 +65
|
apis/core/v1alpha1/common_types.go
Outdated
| // UpdateReplicas is the number of Instances created by the Group controller from the Group version | ||
| // indicated by updateRevision. | ||
| UpdatedReplicas int32 `json:"updatedReplicas,omitempty"` | ||
| UpdateReplicas int32 `json:"updateReplicas"` |
There was a problem hiding this comment.
Why change this? StatefulSet also use updatedReplicas instead of updateReplicas
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/stateful-set-v1/#StatefulSetStatus
|
@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // TODO(liubo02): version of a group is hard to understand | ||
| // We need to change it to a more meaningful field |
There was a problem hiding this comment.
We need a field to indicate if a group is upgrading.
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
