Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add UT for config pkg; mirror fix #6006

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.69%. Comparing base (3a93897) to head (a53ccb2).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6006      +/-   ##
==============================================
+ Coverage       21.14%   23.69%   +2.54%     
==============================================
  Files             152      152              
  Lines           10379    10401      +22     
==============================================
+ Hits             2195     2464     +269     
+ Misses           7972     7721     -251     
- Partials          212      216       +4     
Flag Coverage Δ
unittest 23.69% <92.45%> (+2.54%) ⬆️

Copy link
Contributor

ti-chi-bot bot commented Dec 23, 2024

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 56a1888 into pingcap:feature/v2 Dec 23, 2024
6 of 7 checks passed
@csuzhangxc csuzhangxc deleted the ut-config2 branch December 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants