Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minReadySeconds): support minReadySeconds for PD #5827

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Oct 31, 2024

What problem does this PR solve?

ref pingcap/tiup#2461

closes #5764

also ref #4675

The better method is to check whether if PD is ready via an API from PD (in later versions)

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code
# tidb.pingcap.com/pd-min-ready-seconds: 180

basic-pd-0                         1/1     Running   1 (66m ago)   66m
basic-pd-1                         1/1     Running   1 (70m ago)   70m
basic-pd-2                         1/1     Running   1 (74m ago)   74m

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge October 31, 2024 07:54
@ti-chi-bot ti-chi-bot bot added the size/M label Oct 31, 2024
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 21.06%. Comparing base (9ef26f8) to head (211d3cc).
Report is 35 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (211d3cc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (211d3cc)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5827       +/-   ##
===========================================
- Coverage   61.47%   21.06%   -40.42%     
===========================================
  Files         235      219       -16     
  Lines       30653    30976      +323     
===========================================
- Hits        18843     6524    -12319     
- Misses       9920    23464    +13544     
+ Partials     1890      988      -902     
Flag Coverage Δ
e2e 21.06% <46.15%> (?)
unittest ?

Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit cb809c8 into pingcap:master Oct 31, 2024
5 checks passed
@csuzhangxc csuzhangxc deleted the pd-min-ready branch October 31, 2024 12:41
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5830.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Oct 31, 2024
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5831.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc added a commit that referenced this pull request Nov 1, 2024
csuzhangxc added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure pd leader is ready to serve when rolling update pd
4 participants