validate additionalContainers.image to make sure it is not empty (#3378…

…) (#3383)
pingcap · Oct 15, 2020 · f59ba26 · f59ba26
1 parent 1b9a6e5
commit f59ba26
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/pkg/apis/pingcap/v1alpha1/validation/validation.go b/pkg/apis/pingcap/v1alpha1/validation/validation.go
@@ -193,6 +193,7 @@ func validateComponentSpec(spec *v1alpha1.ComponentSpec, fldPath *field.Path) fi
 	allErrs := field.ErrorList{}
 	// TODO validate other fields
 	allErrs = append(allErrs, validateEnv(spec.Env, fldPath.Child("env"))...)
+	allErrs = append(allErrs, validateAdditionalContainers(spec.AdditionalContainers, fldPath.Child("additionalContainers"))...)
 	return allErrs
 }
 
@@ -481,3 +482,16 @@ func validateTimeDurationStr(timeStr *string, fldPath *field.Path) field.ErrorLi
 	}
 	return allErrs
 }
+
+func validateAdditionalContainers(containers []corev1.Container, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+
+	for i, container := range containers {
+		idxPath := fldPath.Index(i)
+		if len(container.Image) == 0 {
+			allErrs = append(allErrs, field.Required(idxPath.Child("image"), "empty image"))
+		}
+	}
+
+	return allErrs
+}