fix potential goroutine leak (#4291) (#4294)

pingcap · Dec 8, 2021 · b3acd74 · b3acd74
1 parent 9228811
commit b3acd74
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/pkg/tikvapi/tikvapi.go b/pkg/tikvapi/tikvapi.go
@@ -56,8 +56,12 @@ func (c *tikvClient) GetLeaderCount() (int, error) {
 		}
 	}()
 
-	for mf := range mfChan {
-		fm := prom2json.NewFamily(mf)
+	fms := []*prom2json.Family{}
+	for mfc := range mfChan {
+		fm := prom2json.NewFamily(mfc)
+		fms = append(fms, fm)
+	}
+	for _, fm := range fms {
 		if fm.Name == metricNameRegionCount {
 			for _, m := range fm.Metrics {
 				if m, ok := m.(prom2json.Metric); ok && m.Labels["type"] == labelNameLeaderCount {