Limit proxy's memory from TiFlash's side #408
Conversation
Signed-off-by: Calvin Neo <[email protected]>
|
/retest |
|
/hold for tiflash pr |
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
|
/retest |
| @@ -281,6 +281,18 @@ pub unsafe fn run_proxy( | |||
| .help("Set engine role label") | |||
| .takes_value(true), | |||
| ) | |||
| .arg( | |||
| Arg::with_name("memory-limit-size") | |||
There was a problem hiding this comment.
Or _bytes? Seems that in proxy they don't append bytes as a suffix here
There was a problem hiding this comment.
I think "memory-limit-size" is OK. TiKV usually use "-size" for the config item in bytes
https://docs.pingcap.com/tidb/stable/tikv-configuration-file#blob-cache-size
[LGTM Timeline notifier]Timeline:
|
|
/hold memory limit high water ratio to 0.9 |
Signed-off-by: Calvin Neo <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
|
/unhold |
What is changed and how it works?
Issue Number: Close tiflash#9745
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note