fix: fix debug paramters (#1652)

pingcap · Aug 30, 2024 · 9d2b0ce · 9d2b0ce
1 parent 6cfa4e5
commit 9d2b0ce
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/ui/packages/tidb-dashboard-for-op/.env.development b/ui/packages/tidb-dashboard-for-op/.env.development
@@ -3,4 +3,4 @@ PUBLIC_URL='/dashboard'
 REACT_APP_VERSION=$npm_package_version
 REACT_APP_MIXPANEL_HOST=https://telemetry.pingcap.com/api/v1/dashboard/report
 REACT_APP_MIXPANEL_TOKEN=
-REACT_APP_DASHBOARD_API_URL=http://127.0.0.1:2379
+REACT_APP_DASHBOARD_API_URL=http://127.0.0.1:12333
diff --git a/util/rest/error_resp.go b/util/rest/error_resp.go
@@ -7,6 +7,8 @@ import (
 	"strings"
 
 	"github.com/joomcode/errorx"
+	"github.com/pingcap/log"
+	"go.uber.org/zap/zapcore"
 )
 
 type ErrorResponse struct {
@@ -94,11 +96,16 @@ func buildDetailMessage(err error) string {
 }
 
 func NewErrorResponse(err error) ErrorResponse {
+	logLevel := log.GetLevel()
+	fullText := ""
+	if logLevel == zapcore.DebugLevel {
+		fullText = buildDetailMessage(err)
+	}
 	return ErrorResponse{
 		Error:   true,
 		Message: buildSimpleMessage(err),
 		Code:    removeErrorPrefix(buildCode(err)),
-		// For security reasons, we need to hide detailed stacktrace info.
-		// FullText: buildDetailMessage(err),
+		// For security reasons, we need to hide detailed stacktrace info in prod.
+		FullText: fullText,
 	}
 }