drainer: if all DML is filtered, return true ignore (#1320)

close #1317
pingcap · Sep 9, 2024 · fc4e5d0 · fc4e5d0
1 parent 62ff2df
commit fc4e5d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/drainer/syncer.go b/drainer/syncer.go
@@ -660,7 +660,9 @@ func skipDMLEvent(pv *pb.PrewriteValue, schema *Schema, filter *filter.Filter, b
 			mutation.DeletedRows = mutation.DeletedRows[0:filteredDeleteIdx]
 		}
 
-		muts = append(muts, mutation)
+		if len(mutation.Sequence) > 0 {
+			muts = append(muts, mutation)
+		}
 	}
 
 	pv.Mutations = muts

diff --git a/drainer/syncer_test.go b/drainer/syncer_test.go
@@ -54,7 +54,7 @@ func (s *syncerSuite) TestFilterTable(c *check.C) {
 	// append one mutation that will not be dropped
 	var keepID int64 = 2
 	schema.tableIDToName[keepID] = TableName{Schema: "keep", Table: "keep"}
-	pv.Mutations = append(pv.Mutations, pb.TableMutation{TableId: keepID})
+	pv.Mutations = append(pv.Mutations, pb.TableMutation{TableId: keepID, Sequence: []pb.MutationType{pb.MutationType_Insert}})
 
 	ignore, err = skipDMLEvent(pv, schema, filter, nil)
 	c.Assert(err, check.IsNil)