br: add more fields for merged backup SST #1282
Conversation
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
| @@ -147,6 +147,15 @@ message BackupRange { | |||
| repeated File files = 3; | |||
| } | |||
|
|
|||
| // The message saves the physical table checksum | |||
| message TableMeta { | |||
There was a problem hiding this comment.
feels like the name could be TableChecksum unless if you want to add more fields in the future?
There was a problem hiding this comment.
Actually I named it TableChecksum at first, but now I prefer to named it TableMeta. That's because TableMeta is also used to mark the real kvs in the SST file.
- If we have backed up an SST file like this:
[ table0:[kv1, kv2, ...], table1:[kv1, kv2, ...], ... ]
However, another SST file is backed up and is overlapped with the above SST file.
[ table1:[kv1, kv2, ...], ... ]
Therefore, BR remove the TableMeta::table1 in the first SST file metafile and nowTableMetashows which kvs in the SST file is actually valid. - When BR filters out some tables, BR also removes these
TableMetas to mark the skipped kvs.
So in summary, TableMeta does not only used for checksum.
There was a problem hiding this comment.
got it, makes sense, thanks for the clarification.
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.